Project

General

Profile

Defect #64

build script - Set VersionInfoVersion for Inno Setup installer dynamically

Added by Deoren Moor about 6 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Low
Assignee:
Category:
Build scripts
Target version:
Start date:
01/02/2011
Due date:
% Done:

0%

Affected Version:
devel
Resolution:
Fixed

Description

This is a nit-picky thing. I figure 1.0.X (where X is the SVN Rev) would do. The Product version info would still be set via the placeholder replacement process.

Associated revisions

Revision 103 (diff)
Added by Deoren Moor about 6 years ago

[issues #64]
build script:

I used the same logic from r99.

  • I commented out the VersionInfoVersion preprocessor variable and am passing it via command-line. It doesn't seem that command-line Inno Setup variables override those set within the project file.
  • Passing in OUTPUT_DIR to build_innosetup_installer. I was using it without passing it in successfully due to it being a global var. If the functions are moved to their own file (prob soon to come), it would stop working.

Revision 104 (diff)
Added by Deoren Moor about 6 years ago

[issues #64]
Added OUTPUT_DIR to function def like I should have done in the last commit.

Revision 105 (diff)
Added by Deoren Moor about 6 years ago

[issues 64]
Corrected iss_version value. I didn't mean to copy/paste verbatim from the build_wix_project function.

Revision 106 (diff)
Added by Deoren Moor about 6 years ago

[issues #64]
Fixed the logic for VersionInfoVersion. What I had before worked fine for testing releases but not stable ones.

History

#1 Updated by Deoren Moor about 6 years ago

  • Status changed from Assigned to Closed
  • Resolution set to Fixed

Implemented in r103 through r106.

Also available in: Atom PDF