Project

General

Profile

Feature #69

Add option to installers for keeping sources.ini

Added by Deoren Moor over 6 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Installers
Target version:
Start date:
01/03/2011
Due date:
% Done:

100%

Resolution:
Fixed

Description

I recently made a change to the build script which included a copy of sources.ini as one of the files to be installed. This works fine for the archives, as the user would have to manually remove the file if they no longer want it.

With the Inno Setup installer however, it is now removed as part of the uninstall process. Making a backup first is covered in the Upgrade notes, but it's a good idea to offer the option to keep the file to users.

Associated revisions

Revision 110 (diff)
Added by Deoren Moor over 6 years ago

[issues #69]
Inno Setup installer: Asking user during start of uninstall whether they wish to keep sources.ini file. cache.ini isn't part of the install, so it's kept if the user uninstalls.

Revision 111 (diff)
Added by Deoren Moor over 6 years ago

[issues #69]
Fixed copy/paste bug.

Revision 112 (diff)
Added by Deoren Moor over 6 years ago

[issues #69]
This is another one of those times I shouldn't code. I was checking for IDYES instead of IDNO.

Revision 114 (diff)
Added by Deoren Moor over 6 years ago

[issues #69]
I had to exclude sources.ini from the wildcard inclusion. I also set the onlyifdoesntexist flag so a modified copy wouldn't be overwritten. That should take care of most "oops" cases during upgrades.

Revision 115 (diff)
Added by Deoren Moor over 6 years ago

[issues #69]
Indented procedure consistently.

Revision 133 (diff)
Added by Deoren Moor over 6 years ago

[issues #69]
Reversed earlier changes for the Inno Setup project file.

I've decided to copy over sources.ini.dist to the package_dir as sources.example.ini instead of sources.ini. This means that the installer will not touch sources.ini by default. Any changes the user makes stays.

This will make having the same functionality in the WiX project easier to implement.

Revision 134 (diff)
Added by Deoren Moor over 6 years ago

[issues #69]
Added comment to sources.dist.ini to make it clearer what the purpose of the file is.

Revision 137 (diff)
Added by Deoren Moor over 6 years ago

[issues #69]
Removing update_dist_files function was it wasn't needed and am no longer placing sources.dist.ini in the package_dir as sources.ini.

History

#1 Updated by Deoren Moor over 6 years ago

Still not working. I'm overlooking something.

#2 Updated by Deoren Moor over 6 years ago

As of r114, sources.ini is kept safe during an install (doesn't install it if it already exists) and user is asked if they'd like to keep it when uninstalling.

Now on to the MSI version.

#3 Updated by Deoren Moor over 6 years ago

  • % Done changed from 0 to 50

#4 Updated by Deoren Moor over 6 years ago

  • Status changed from Assigned to Closed
  • % Done changed from 50 to 100
  • Resolution set to Fixed

As of r144, both WiX and Inno Setup installers leave sources.ini, cache.ini and other directory content alone during installation and removal.

Also available in: Atom PDF